Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced whitelist_externals with allowlist_externals in tox and removed tox-battery #286

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Replaced whitelist_externals with allowlist_externals in tox and removed tox-battery #286

merged 4 commits into from
Nov 13, 2023

Conversation

zubairshakoorarbisoft
Copy link
Contributor

@zubairshakoorarbisoft zubairshakoorarbisoft requested a review from a team as a code owner October 31, 2023 12:40
@zubairshakoorarbisoft zubairshakoorarbisoft mentioned this pull request Oct 31, 2023
Closed
@farhan farhan requested a review from feanil November 10, 2023 08:26
@farhan farhan requested review from feanil and removed request for feanil November 10, 2023 08:29
felipemontoya
felipemontoya reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand all the specifics of the tox change but the change itself looks good to me.
There is a need for a rebase still, but I'll be happy to approve an merge when that is done.

@UsamaSadiq
Copy link
Member

@felipemontoya the PR has been rebased. Please review and merge the PR. Thanks.
FYI for context, this change has been made across all the edx/openedx repositories already.

@mariajgrimaldi mariajgrimaldi merged commit 24ed9ce into openedx:main Nov 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipemontoya felipemontoya felipemontoya left review comments

@salman2013 salman2013 salman2013 approved these changes

@farhan farhan farhan approved these changes

@UsamaSadiq UsamaSadiq UsamaSadiq approved these changes

@mariajgrimaldi mariajgrimaldi mariajgrimaldi approved these changes

@feanil feanil Awaiting requested review from feanil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zubairshakoorarbisoft @UsamaSadiq @felipemontoya @salman2013 @farhan @mariajgrimaldi @edx-requirements-bot